EHC ❯ Race condition in Ehcache disk overflow storage initialization

• Type: Bug
• Status: Closed
• Priority: 2 Major
• Resolution: Fixed
• Component/s: ehcache-core
• Labels:

• Assignee: cdennis
• Reporter: tg
• Created: November 21, 2011
• Votes: 0
• Watchers: 2
• Updated:

  July 27, 2012
• Resolved:

  November 21, 2011

Description

DiskOverflowStorageFactory.getDataFile creates the temp directory if it does not yet exist:

if (!diskDir.exists() && !diskDir.mkdirs()) {
   throw new CacheException("Could not create cache directory \"" + diskDir.getAbsolutePath() + "\".");
}

Unfortunately, there is a race condition in this code fragment that causes trouble if the directory is created between the diskDir.exists() and diskDir.mkdirs() calls (diskDir.mkdirs() will return false if the directory already exists).

Patch proposal:

if (!diskDir.exists() && !diskDir.mkdirs() && !diskDir.exists()) {
   throw new CacheException("Could not create cache directory \"" + diskDir.getAbsolutePath() + "\".");
}

Comments

Fiona OShea 2011-11-21

Is this a bug we should fix soon?