Lock eviction fails (as per spec) when lock is not pinned

Type: Bug
Status: Closed
Priority: 2 Major
Resolution: Not a Bug
Component/s: DSO:L1
Labels:

Assignee: cdennis
Reporter: cdennis
Created: July 22, 2009
Votes: 0
Watchers: 1
Updated:
January 14, 2010
Resolved:
November 16, 2009

Description

The current “spec” (the javadoc) for manual lock management defines the eviction of a unpinned lock as a no-op. For the ConcurrentDistributedMap this means that remove operations on previously non-local keys do not evict (and therefore recall) the associated key lock (as the lock will not be pinned as it is not local on entry to the method). The fix to change this behavior is a one-liner in the ClientLock class.

Comments

Fiona OShea 2009-07-22

What problem are we trying to solve? Is it necessary for 3.1?

Chris Dennis 2009-07-22

As of the moment I have no proof that this is a bottleneck. I filed this simply to make sure that the “bug”s existence was recorded. If we find it to be a bottleneck then I will obviously post a comment here.

Fiona OShea 2009-07-22

thanks Chris. I’ll move out to Santiago, if we find it is an issue we will move it back to Rivera

Chris Dennis 2009-11-16

I’m closing this since the evictLock method no longer exists in the new lock implementation, and as it was never shown to be a bottleneck in CSM (the only code that I know of that uses it) I’m reluctant to rock the 3.1 boat in order to fix it.